Added Randomized Relationship History for Personnel #4512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a new feature to simulate relationship histories, including marriage, procreation, and divorce for new campaign personnel. Enhanced the settings panel to include options for this new feature.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4512 +/- ##
============================================
- Coverage 10.33% 10.33% -0.01%
- Complexity 5824 5826 +2
============================================
Files 935 935
Lines 128395 128550 +155
Branches 18889 18921 +32
============================================
+ Hits 13270 13280 +10
- Misses 113849 113992 +143
- Partials 1276 1278 +2 ☔ View full report in Codecov by Sentry. |
Previously, the system did not correctly handle clan members when simulating relationship history. Added a check to exclude clan members from simulated relationship history updates.
|
Rather than having this and #4521 as separate PRs, I'm going to merge the two. As the scope of #4521 increases the number of conflicts between the two are similarly increased to the point where the amount of work required to merge the two PRs is less than the amount of work required to fix all the current and future compatibility issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be merged before #4521
Implemented a new feature to simulate relationship histories, including marriage, procreation, and divorce for new campaign personnel. Enhanced the settings panel to include options for this new feature.
Should be merged after #4463. Originally this PR was just going to be a small extension to 4463, but it ballooned - as such things are want to do.